From 74d9b259e3ff4bab5cb94ca0eda87852e94977de Mon Sep 17 00:00:00 2001 From: Herman Schaaf Date: Sun, 28 Jul 2019 21:26:00 +0100 Subject: [PATCH] fix linting errors --- database/db.go | 2 ++ handlers/badge.go | 1 + handlers/check.go | 1 + handlers/high_scores.go | 1 + handlers/home.go | 3 ++- handlers/report.go | 1 + vendor/github.com/siddontang/go/ioutil2/ioutil.go | 2 +- .../github.com/syndtr/goleveldb/leveldb/storage/mem_storage.go | 2 +- 8 files changed, 10 insertions(+), 3 deletions(-) diff --git a/database/db.go b/database/db.go index 88fc5f5..eb37317 100644 --- a/database/db.go +++ b/database/db.go @@ -9,6 +9,8 @@ import ( "github.com/siddontang/ledisdb/ledis" ) +// Database represents the main functions that should be made available by a GRC database +// implementation type Database interface { GetRepo(string) (string, error) SetRepo(repo string, value string) error diff --git a/handlers/badge.go b/handlers/badge.go index e690fd6..ffaa8e8 100644 --- a/handlers/badge.go +++ b/handlers/badge.go @@ -10,6 +10,7 @@ import ( "github.com/gojp/goreportcard/database" ) +// BadgeHandler handles fetching badge images type BadgeHandler struct { DB database.Database } diff --git a/handlers/check.go b/handlers/check.go index 0580a1b..694b18a 100644 --- a/handlers/check.go +++ b/handlers/check.go @@ -12,6 +12,7 @@ import ( "github.com/gojp/goreportcard/download" ) +// CheckHandler handles requests for checking repos type CheckHandler struct { DB database.Database } diff --git a/handlers/high_scores.go b/handlers/high_scores.go index 858f952..30a95a0 100644 --- a/handlers/high_scores.go +++ b/handlers/high_scores.go @@ -25,6 +25,7 @@ func formatScore(x float64) string { return fmt.Sprintf("%.2f", x) } +// HighScoresHandler handles the stats page type HighScoresHandler struct { DB database.Database } diff --git a/handlers/home.go b/handlers/home.go index bb56e1a..feccf66 100644 --- a/handlers/home.go +++ b/handlers/home.go @@ -8,11 +8,12 @@ import ( "github.com/gojp/goreportcard/database" ) +// HomeHandler handles the homepage type HomeHandler struct { DB database.Database } -// HomeHandler handles the homepage +// Handle handles the homepage func (h *HomeHandler) Handle(w http.ResponseWriter, r *http.Request) { if r.URL.Path[1:] == "" { diff --git a/handlers/report.go b/handlers/report.go index 6ddbafb..734ccc9 100644 --- a/handlers/report.go +++ b/handlers/report.go @@ -14,6 +14,7 @@ import ( var domain = flag.String("domain", "goreportcard.com", "Domain used for your goreportcard installation") var googleAnalyticsKey = flag.String("google_analytics_key", "UA-58936835-1", "Google Analytics Account Id") +// ReportHandler handles the report page type ReportHandler struct { DB database.Database } diff --git a/vendor/github.com/siddontang/go/ioutil2/ioutil.go b/vendor/github.com/siddontang/go/ioutil2/ioutil.go index 35c0ad3..2fa4520 100644 --- a/vendor/github.com/siddontang/go/ioutil2/ioutil.go +++ b/vendor/github.com/siddontang/go/ioutil2/ioutil.go @@ -13,7 +13,7 @@ import ( // Write file to temp and atomically move when everything else succeeds. func WriteFileAtomic(filename string, data []byte, perm os.FileMode) error { - dir, name := path.Dir(filename), path.Base(filename) + dir, name := path.Dir(filename), path.Base(filename) f, err := ioutil.TempFile(dir, name) if err != nil { return err diff --git a/vendor/github.com/syndtr/goleveldb/leveldb/storage/mem_storage.go b/vendor/github.com/syndtr/goleveldb/leveldb/storage/mem_storage.go index 9b70e15..bf712f9 100644 --- a/vendor/github.com/syndtr/goleveldb/leveldb/storage/mem_storage.go +++ b/vendor/github.com/syndtr/goleveldb/leveldb/storage/mem_storage.go @@ -78,7 +78,7 @@ func (ms *memStorage) GetMeta() (FileDesc, error) { func (ms *memStorage) List(ft FileType) ([]FileDesc, error) { ms.mu.Lock() var fds []FileDesc - for x, _ := range ms.files { + for x := range ms.files { fd := unpackFile(x) if fd.Type&ft != 0 { fds = append(fds, fd)