From c6501ec0effb55ac63a5a87c6a4300021ee3840a Mon Sep 17 00:00:00 2001 From: Shawn Smith Date: Sat, 3 Oct 2015 16:55:39 +0900 Subject: [PATCH] simplify error check --- handlers/checks.go | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/handlers/checks.go b/handlers/checks.go index 519815b..3b953a8 100644 --- a/handlers/checks.go +++ b/handlers/checks.go @@ -82,13 +82,16 @@ func clone(url string) error { if err := cmd.Run(); err != nil { return fmt.Errorf("could not run git clone: %v", err) } - } else if err != nil { + + return nil + } + if err != nil { return fmt.Errorf("could not stat dir: %v", err) - } else { - cmd := exec.Command("git", "-C", dir, "pull") - if err := cmd.Run(); err != nil { - return fmt.Errorf("could not pull repo: %v", err) - } + } + + cmd := exec.Command("git", "-C", dir, "pull") + if err := cmd.Run(); err != nil { + return fmt.Errorf("could not pull repo: %v", err) } return nil