add back RevertFiles for CLI #397

check/check.go

@@ -38,7 +38,7 @@ type ChecksResult struct {
 }
 
 // Run executes all checks on the given directory
-func Run(dir string) (ChecksResult, error) {
+func Run(dir string, cli bool) (ChecksResult, error) {
 	filenames, skipped, err := GoFiles(dir)
 	if err != nil {
 		return ChecksResult{}, fmt.Errorf("could not get filenames: %v", err)
@@ -52,6 +52,10 @@ func Run(dir string) (ChecksResult, error) {
 		log.Println("Could not rename files:", err)
 	}
 
+	if cli {
+		defer RevertFiles(skipped)
+	}
+
 	checks := []Check{
 		GoFmt{Dir: dir, Filenames: filenames},
 		GoVet{Dir: dir, Filenames: filenames},

check/utils.go

@@ -82,6 +82,19 @@ func RenameFiles(names []string) (err error) {
 	return err
 }
 
+// RevertFiles removes the ".grc.bk" extension from files
+func RevertFiles(names []string) (err error) {
+	for i := range names {
+		tmpErr := os.Rename(names[i]+".grc.bk", names[i])
+		if tmpErr != nil {
+			// save this error, but still continue with other files
+			err = tmpErr
+		}
+	}
+
+	return err
+}
+
 // lineCount returns the number of lines in a given file
 func lineCount(filepath string) (int, error) {
 	out, err := exec.Command("wc", "-l", filepath).Output()

cmd/goreportcard-cli/main.go

@@ -34,7 +34,7 @@ func dotPrintf(fullLen int, lfStr, rtFmtStr string, args ...interface{}) {
 func main() {
 	flag.Parse()
 
-	result, err := check.Run(*dir)
+	result, err := check.Run(*dir, true)
 	if err != nil {
 		log.Fatalf("Fatal error checking %s: %s", *dir, err.Error())
 	}

handlers/checks.go

@@ -99,7 +99,7 @@ func newChecksResp(db *badger.DB, repo string, forceRefresh bool) (checksResp, e
 		return checksResp{}, fmt.Errorf("could not download repo: %v", err)
 	}
 
-	checkResult, err := check.Run(dirName(repo, ver))
+	checkResult, err := check.Run(dirName(repo, ver), false)
 	if err != nil {
 		return checksResp{}, err
 	}