Fixing megacheck issues reported by gometalinter

tools/clean-repos/main.go

@@ -26,7 +26,7 @@ func main() {
 			}
 			for _, d := range dirs {
 				path := "_repos/src/" + f.Name() + "/" + d.Name()
-				if time.Now().Sub(d.ModTime()) > 30*24*time.Hour {
+				if time.Since(d.ModTime()) > 30*24*time.Hour {
 					if *real {
 						log.Printf("Deleting %s (repo is old)...", path)
 						os.RemoveAll(path)

tools/db/manage_db.go

@@ -56,12 +56,7 @@ func deleteRepo(repo string) error {
 			return err
 		}
 
-		err = mb.Put([]byte("scores"), scoreBytes)
-		if err != nil {
-			return err
-		}
-
-		return nil
+		return mb.Put([]byte("scores"), scoreBytes)
 	})
 
 }
@@ -110,7 +105,7 @@ func listDuplicates() error {
 
 func main() {
 	flag.Parse()
-	if *repo == "" && *listDupes == false {
+	if *repo == "" && !*listDupes {
 		log.Println("Usage: manage_db.go [-list-duplicates] [-remove repo]")
 		return
 	}

tools/names/migrate_repo_names.go

@@ -75,12 +75,7 @@ func main() {
 		if err != nil {
 			return err
 		}
-		err = mb.Put([]byte("scores"), scoreBytes)
-		if err != nil {
-			return err
-		}
-
-		return nil
+		return mb.Put([]byte("scores"), scoreBytes)
 	})
 	if err != nil {
 		log.Fatal(err)

tools/scores/init_repo_scores.go

@@ -10,10 +10,7 @@ import (
 	"github.com/gojp/goreportcard/handlers"
 )
 
-const (
-	repoBucket string = "repos"
-	metaBucket string = "meta"
-)
+const repoBucket = "repos"
 
 type checksResp struct {
 	Repo    string  `json:"repo"`