actions/unity-builder
2
0
Fork 0
mirror of https://github.com/game-ci/unity-builder.git synced 2026-02-03 23:49:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

pr feedback

Browse Source
This commit is contained in:
Frostebite
2026-01-19 04:46:23 +00:00
parent dc7c16ce58
commit 4b09fe3615
3 changed files with 16 additions and 133 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
dist/index.js generated vendored
View File

@@ -3779,35 +3779,6 @@ class Kubernetes {
cloud_runner_logger_1.default.log(`Cleanup command failed (non-fatal): ${cmdError}`);
}
}
// Verify Unity image is cached on the AGENT node (where pods run)
// This is critical - if the image isn't on the agent node, pods will try to pull it
let unityImageCached = false;
try {
const unityImageCheckAgent = await CloudRunnerSystem.Run(`docker exec k3d-unity-builder-agent-0 sh -c "crictl images | grep -q unityci/editor && echo 'found' || echo 'not found'" || echo 'not found'`, true, true);
unityImageCached = unityImageCheckAgent.includes('found');
cloud_runner_logger_1.default.log(`Unity image cache status on agent node: ${unityImageCached ? 'CACHED' : 'NOT CACHED'}`);
if (!unityImageCached) {
// Check if it's on the server node (might need to be copied)
const unityImageCheckServer = await CloudRunnerSystem.Run(`docker exec k3d-unity-builder-server-0 sh -c "crictl images | grep -q unityci/editor && echo 'found' || echo 'not found'" || echo 'not found'`, true, true);
cloud_runner_logger_1.default.log(`Unity image cache status on server node: ${unityImageCheckServer.includes('found') ? 'CACHED' : 'NOT CACHED'}`);
// Check available disk space
const diskCheck = await CloudRunnerSystem.Run('docker exec k3d-unity-builder-agent-0 sh -c "df -h /var/lib/rancher/k3s 2>/dev/null | tail -1 | awk \'{print $4}\' || df -h / 2>/dev/null | tail -1 | awk \'{print $4}\' || echo unknown" || echo unknown', true, true);
cloud_runner_logger_1.default.log(`Available disk space on agent node: ${diskCheck.trim()}`);
// Unity image is ~3.9GB, so we need at least 4-5GB free
// If we have less than 4GB, warn that pull will likely fail
const availableSpaceStr = diskCheck.trim().toLowerCase();
if (availableSpaceStr.includes('g')) {
const availableGB = parseFloat(availableSpaceStr);
if (availableGB < 4) {
cloud_runner_logger_1.default.logWarning(`WARNING: Unity image not cached and only ${availableGB}GB available. Image pull (3.9GB) will likely fail due to disk pressure.`);
}
}
}
}
catch {
// Ignore check failures - continue and hope image is cached
cloud_runner_logger_1.default.logWarning('Failed to check Unity image cache status');
}
}
catch (cleanupError) {
cloud_runner_logger_1.default.logWarning(`Failed to cleanup images before job creation: ${cleanupError}`);
@@ -3829,27 +3800,14 @@ class Kubernetes {
// Check available disk space on agent node
const diskInfo = await CloudRunnerSystem.Run('docker exec k3d-unity-builder-agent-0 sh -c "df -h /var/lib/rancher/k3s 2>/dev/null | tail -1 || df -h / 2>/dev/null | tail -1 || echo unknown" || echo unknown', true, true);
cloud_runner_logger_1.default.logWarning(`Unity image not cached on agent node (where pods run). Server node: ${serverImageCheck.includes('cached') ? 'has image' : 'no image'}. Disk info: ${diskInfo.trim()}. Pod will attempt to pull image (3.9GB) which may fail due to disk pressure.`);
// If image is on server but not agent, try to pull it on agent
// This is a best-effort attempt - if it fails, the pod will try anyway
// If image is on server but not agent, log a warning
// NOTE: We don't attempt to pull here because:
// 1. Pulling a 3.9GB image can take several minutes and block the test
// 2. If there's not enough disk space, the pull will hang indefinitely
// 3. The pod will attempt to pull during scheduling anyway
// 4. If the pull fails, Kubernetes will provide proper error messages
if (serverImageCheck.includes('cached')) {
cloud_runner_logger_1.default.log('Unity image exists on server node but not agent node. Attempting to pull on agent node to avoid pod pull failures...');
try {
// Use crictl to pull the image on the agent node
// Note: This might fail if there's not enough space, but we'll try anyway
const pullOutput = await CloudRunnerSystem.Run(`docker exec k3d-unity-builder-agent-0 sh -c "crictl pull ${image} 2>&1" || true`, true, true);
cloud_runner_logger_1.default.log(`Image pull attempt on agent node: ${pullOutput}`);
// Verify the pull succeeded
const verifyPull = await CloudRunnerSystem.Run(`docker exec k3d-unity-builder-agent-0 sh -c "crictl images | grep -q unityci/editor && echo 'pull_success' || echo 'pull_failed'" || echo 'pull_failed'`, true, true);
if (verifyPull.includes('pull_success')) {
cloud_runner_logger_1.default.log('Successfully pulled Unity image on agent node');
}
else {
cloud_runner_logger_1.default.logWarning('Failed to pull Unity image on agent node. Pod will attempt pull during scheduling, which may fail due to disk pressure.');
}
}
catch (pullError) {
cloud_runner_logger_1.default.logWarning(`Failed to pre-pull image on agent node: ${pullError}. Pod will attempt pull during scheduling.`);
}
cloud_runner_logger_1.default.logWarning('Unity image exists on server node but not agent node. Pod will attempt to pull during scheduling. If pull fails due to disk pressure, ensure cleanup runs before this test.');
}
else {
// Image not on either node - check if we have enough space to pull

2
dist/index.js.map generated vendored
View File

File diff suppressed because one or more lines are too long