pr feedback

This commit is contained in:
Frostebite
2025-12-06 23:00:43 +00:00
parent c61c9f8373
commit a99defafbc
18 changed files with 190 additions and 152 deletions

View File

@@ -66,9 +66,9 @@ describe('Cloud Runner pre-built rclone steps', () => {
cloudRunnerDebug: true,
} as unknown as OptionValues;
const buildParams = await CreateParameters(overrides);
const baseImage = new ImageTag(buildParams);
const results = await CloudRunner.run(buildParams, baseImage.toString());
const buildParameters = await CreateParameters(overrides);
const baseImage = new ImageTag(buildParameters);
const results = await CloudRunner.run(buildParameters, baseImage.toString());
CloudRunnerLogger.log(`rclone run succeeded`);
expect(results.BuildSucceeded).toBe(true);

View File

@@ -96,6 +96,7 @@ describe('Cloud Runner Retain Workspace', () => {
CloudRunnerLogger.log(`Failed to cleanup workspace: ${error.message}`);
}
}
// Clean up cache files to prevent disk space issues
const cachePath = `./cloud-runner-cache`;
if (fs.existsSync(cachePath)) {

View File

@@ -1,6 +1,9 @@
import { GitHubUrlInfo } from '../../providers/provider-url-parser';
import * as fs from 'fs';
// Import the mocked ProviderGitManager
import { ProviderGitManager } from '../../providers/provider-git-manager';
// Mock @actions/core to fix fs.promises compatibility issue
jest.mock('@actions/core', () => ({
info: jest.fn(),
@@ -15,6 +18,7 @@ jest.mock('fs');
const mockExecAsync = jest.fn();
jest.mock('../../providers/provider-git-manager', () => {
const originalModule = jest.requireActual('../../providers/provider-git-manager');
return {
...originalModule,
ProviderGitManager: {
@@ -27,9 +31,6 @@ jest.mock('../../providers/provider-git-manager', () => {
});
const mockFs = fs as jest.Mocked<typeof fs>;
// Import the mocked ProviderGitManager
import { ProviderGitManager } from '../../providers/provider-git-manager';
const mockProviderGitManager = ProviderGitManager as jest.Mocked<typeof ProviderGitManager>;
describe('ProviderGitManager', () => {