actions/unity-builder
2
0
Fork 0
mirror of https://github.com/game-ci/unity-builder.git synced 2026-02-05 00:39:06 +08:00
Code Issues Packages Projects Releases Wiki Activity

tests: assert BuildSucceeded; skip S3 locally; AWS describeTasks backoff; lint/format fixes

Browse Source
This commit is contained in:
Frostebite
2025-09-03 20:49:52 +01:00
parent eb8b92cda1
commit c8f881a385
6 changed files with 67 additions and 65 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/model/cloud-runner/tests/cloud-runner-s3-steps.test.ts
View File

@@ -54,21 +54,8 @@ describe('Cloud Runner pre-built S3 steps', () => {
const buildParameter2 = await CreateParameters(overrides);
const baseImage2 = new ImageTag(buildParameter2);
const results2Object = await CloudRunner.run(buildParameter2, baseImage2.toString());
const results2 = results2Object.BuildResults;
CloudRunnerLogger.log(`run 2 succeeded`);
// Look for multiple indicators of a successful build
const buildIndicators = [
'Build succeeded',
'Build succeeded!',
'Build Succeeded',
'succeeded',
'Cloud Runner finished running standard build automation',
'Cloud runner job has finished successfully',
];
const buildWasSuccessful = buildIndicators.some((indicator) => results2.includes(indicator));
expect(buildWasSuccessful).toBeTruthy();
expect(results2Object.BuildSucceeded).toBe(true);
// Only run S3 operations if we're in CI or AWS CLI is available
if (isCI || awsAvailable) {

10
src/model/cloud-runner/tests/e2e/cloud-runner-end2end-caching.test.ts
View File

@@ -44,10 +44,10 @@ describe('Cloud Runner Caching', () => {
const results = resultsObject.BuildResults;
const libraryString = 'Rebuilding Library because the asset database could not be found!';
const cachePushFail = 'Did not push source folder to cache because it was empty Library';
const buildSucceededString = 'Build succeeded';
expect(results).toContain(libraryString);
expect(results).toContain(buildSucceededString);
expect(resultsObject.BuildSucceeded).toBe(true);
// Keep minimal assertions to reduce brittleness
expect(results).not.toContain(cachePushFail);
CloudRunnerLogger.log(`run 1 succeeded`);
@@ -72,7 +72,6 @@ describe('Cloud Runner Caching', () => {
CloudRunnerLogger.log(`run 2 succeeded`);
const build2ContainsCacheKey = results2.includes(buildParameter.cacheKey);
const build2ContainsBuildSucceeded = results2.includes(buildSucceededString);
const build2NotContainsZeroLibraryCacheFilesMessage = !results2.includes(
'There is 0 files/dir in the cache pulled contents for Library',
);
@@ -82,8 +81,7 @@ describe('Cloud Runner Caching', () => {
expect(build2ContainsCacheKey).toBeTruthy();
expect(results2).toContain('Activation successful');
expect(build2ContainsBuildSucceeded).toBeTruthy();
expect(results2).toContain(buildSucceededString);
expect(results2Object.BuildSucceeded).toBe(true);
const splitResults = results2.split('Activation successful');
expect(splitResults[splitResults.length - 1]).not.toContain(libraryString);
expect(build2NotContainsZeroLibraryCacheFilesMessage).toBeTruthy();

9
src/model/cloud-runner/tests/e2e/cloud-runner-end2end-retaining.test.ts
View File

@@ -34,10 +34,10 @@ describe('Cloud Runner Retain Workspace', () => {
const results = resultsObject.BuildResults;
const libraryString = 'Rebuilding Library because the asset database could not be found!';
const cachePushFail = 'Did not push source folder to cache because it was empty Library';
const buildSucceededString = 'Build succeeded';
expect(results).toContain(libraryString);
expect(results).toContain(buildSucceededString);
expect(resultsObject.BuildSucceeded).toBe(true);
// Keep minimal assertions to reduce brittleness
expect(results).not.toContain(cachePushFail);
if (CloudRunnerOptions.providerStrategy === `local-docker`) {
@@ -61,7 +61,6 @@ describe('Cloud Runner Retain Workspace', () => {
const build2ContainsBuildGuid1FromRetainedWorkspace = results2.includes(buildParameter.buildGuid);
const build2ContainsRetainedWorkspacePhrase = results2.includes(`Retained Workspace:`);
const build2ContainsWorkspaceExistsAlreadyPhrase = results2.includes(`Retained Workspace Already Exists!`);
const build2ContainsBuildSucceeded = results2.includes(buildSucceededString);
const build2NotContainsZeroLibraryCacheFilesMessage = !results2.includes(
'There is 0 files/dir in the cache pulled contents for Library',
);
@@ -73,7 +72,7 @@ describe('Cloud Runner Retain Workspace', () => {
expect(build2ContainsRetainedWorkspacePhrase).toBeTruthy();
expect(build2ContainsWorkspaceExistsAlreadyPhrase).toBeTruthy();
expect(build2ContainsBuildGuid1FromRetainedWorkspace).toBeTruthy();
expect(build2ContainsBuildSucceeded).toBeTruthy();
expect(results2Object.BuildSucceeded).toBe(true);
expect(build2NotContainsZeroLibraryCacheFilesMessage).toBeTruthy();
expect(build2NotContainsZeroLFSCacheFilesMessage).toBeTruthy();
const splitResults = results2.split('Activation successful');