Cloud runner develop - Stabilizes kubernetes provider (#531)

* fixes * fixes * fixes * fixes * fixes * check for startup message in workflows * check for startup message in workflows * check for startup message in workflows * check for startup message in workflows * check for startup message in workflows * check for startup message in workflows * Update cloud-runner-ci-pipeline.yml * Update cloud-runner-ci-pipeline.yml * no storage class specified * log file path * log file path * log file path * log file path * log file path * log file path * log file path * log file path * updates * log file path * latest develop * log file path * log file path * Update package.json * log file path * log file path * log file path * log file path * log file path * log file path * log file path * log file path * log file path * log file path * log file path * log file path * log file path * log file path * stream logs through standard input and new remote client cli command * stream logs through standard input and new remote client cli command * stream logs through standard input and new remote client cli command * stream logs through standard input and new remote client cli command * stream logs through standard input and new remote client cli command * stream logs through standard input and new remote client cli command * stream logs through standard input and new remote client cli command * stream logs through standard input and new remote client cli command * stream logs through standard input and new remote client cli command * stream logs through standard input and new remote client cli command * stream logs through standard input and new remote client cli command * stream logs through standard input and new remote client cli command * stream logs through standard input and new remote client cli command * stream logs through standard input and new remote client cli command * stream logs through standard input and new remote client cli command * update pipeline to use k3s * version: 'latest' * fixes * disable aws pipe for now * disable aws pipe for now * disable aws pipe for now * disable aws pipe for now * disable aws pipe for now * disable aws pipe for now * disable aws pipe for now * disable aws pipe for now * disable aws pipe for now * disable aws pipe for now * push k8s logs to LOG SERVICE IP * push k8s logs to LOG SERVICE IP * push k8s logs to LOG SERVICE IP * push k8s logs to LOG SERVICE IP * push k8s logs to LOG SERVICE IP * push k8s logs to LOG SERVICE IP * push k8s logs to LOG SERVICE IP * push k8s logs to LOG SERVICE IP * tests * tests * tests * tests * tests * tests * tests * tests * tests * tests * tests * tests * tests * tests * tests * tests * tests * podname logs for log service * podname logs for log service * podname logs for log service * podname logs for log service * podname logs for log service * podname logs for log service * podname logs for log service * podname logs for log service * podname logs for log service * hashed logs * hashed logs * hashed logs * hashed logs * hashed logs * hashed logs * no wait, just repeat logs * no wait, just repeat logs * remove typo - double await * test fix - kubernetes - name typo in github yaml * test fix - kubernetes - name typo in github yaml * check missing log file * check missing log file * Push to steam test * Push to steam test * Fix path * k8s reliable log hashing * k8s reliable log hashing * k8s reliable log hashing * hashed logging k8s * hashed logging k8s * hashed logging k8s * hashed logging k8s * hashed logging k8s * hashed logging k8s * Include log chunk when task runner sees log update, clarify if we can pull logs from same line or next line * Include log chunk when task runner sees log update, clarify if we can pull logs from same line or next line * Include log chunk when task runner sees log update, clarify if we can pull logs from same line or next line * Include log chunk when task runner sees log update, clarify if we can pull logs from same line or next line * Include log chunk when task runner sees log update, clarify if we can pull logs from same line or next line * Fix exit flow for k8s job * hash comparison logging for log complete in k8s flow * Interrupt k8s logs when logs found * cleanup async parameter * cleanup async parameter * cleanup async parameter * fixes * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix * fix
2026-02-04 08:09:08 +08:00 · 2024-02-06 23:46:31 +00:00
parent 2800d14403
commit e73b48fb38
47 changed files with 1456 additions and 856 deletions
--- a/src/model/cloud-runner/tests/cloud-runner-async-workflow.test.ts
+++ b/src/model/cloud-runner/tests/cloud-runner-async-workflow.test.ts
@@ -24,11 +24,17 @@ describe('Cloud Runner Async Workflows', () => {
        unityVersion: UnityVersioning.read('test-project'),
        asyncCloudRunner: `true`,
        githubChecks: `true`,
+        providerStrategy: 'k8s',
+        buildPlatform: 'linux',
+        targetPlatform: 'StandaloneLinux64',
      });
      const baseImage = new ImageTag(buildParameter);

      // Run the job
      await CloudRunner.run(buildParameter, baseImage.toString());
+
+      // wait for 15 seconds
+      await new Promise((resolve) => setTimeout(resolve, 1000 * 60 * 12));
    }, 1_000_000_000);
  }
 });
--- a/src/model/cloud-runner/tests/cloud-runner-environment.test.ts
+++ b/src/model/cloud-runner/tests/cloud-runner-environment.test.ts
@@ -34,6 +34,7 @@ describe('Cloud Runner Sync Environments', () => {
        versioning: 'None',
        projectPath: 'test-project',
        unityVersion: UnityVersioning.read('test-project'),
+        targetPlatform: 'StandaloneWindows64',
        customJob: `
        - name: 'step 1'
          image: 'ubuntu'
@@ -44,9 +45,12 @@ describe('Cloud Runner Sync Environments', () => {
        `,
      });
      const baseImage = new ImageTag(buildParameter);
+      if (baseImage.toString().includes('undefined')) {
+        throw new Error(`Base image is undefined`);
+      }

      // Run the job
-      const file = await CloudRunner.run(buildParameter, baseImage.toString());
+      const file = (await CloudRunner.run(buildParameter, baseImage.toString())).BuildResults;

      // Assert results
      // expect(file).toContain(JSON.stringify(buildParameter));
--- a/src/model/cloud-runner/tests/cloud-runner-github-checks.test.ts
+++ b/src/model/cloud-runner/tests/cloud-runner-github-checks.test.ts
@@ -0,0 +1,59 @@
+import { BuildParameters } from '../..';
+import CloudRunner from '../cloud-runner';
+import UnityVersioning from '../../unity-versioning';
+import { Cli } from '../../cli/cli';
+import CloudRunnerOptions from '../options/cloud-runner-options';
+import setups from './cloud-runner-suite.test';
+import { OptionValues } from 'commander';
+import GitHub from '../../github';
+export const TIMEOUT_INFINITE = 1e9;
+async function CreateParameters(overrides: OptionValues | undefined) {
+  if (overrides) Cli.options = overrides;
+
+  return BuildParameters.create();
+}
+describe('Cloud Runner Github Checks', () => {
+  setups();
+  it('Responds', () => {});
+
+  if (CloudRunnerOptions.cloudRunnerDebug) {
+    it(
+      'Check Handling Direct',
+      async () => {
+        // Setup parameters
+        const buildParameter = await CreateParameters({
+          versioning: 'None',
+          projectPath: 'test-project',
+          unityVersion: UnityVersioning.read('test-project'),
+          asyncCloudRunner: `true`,
+          githubChecks: `true`,
+        });
+        await CloudRunner.setup(buildParameter);
+        CloudRunner.buildParameters.githubCheckId = await GitHub.createGitHubCheck(`direct create`);
+        await GitHub.updateGitHubCheck(`1 ${new Date().toISOString()}`, `direct`);
+        await GitHub.updateGitHubCheck(`2 ${new Date().toISOString()}`, `direct`, `success`, `completed`);
+      },
+      TIMEOUT_INFINITE,
+    );
+    it(
+      'Check Handling Via Async Workflow',
+      async () => {
+        // Setup parameters
+        const buildParameter = await CreateParameters({
+          versioning: 'None',
+          projectPath: 'test-project',
+          unityVersion: UnityVersioning.read('test-project'),
+          asyncCloudRunner: `true`,
+          githubChecks: `true`,
+        });
+        GitHub.forceAsyncTest = true;
+        await CloudRunner.setup(buildParameter);
+        CloudRunner.buildParameters.githubCheckId = await GitHub.createGitHubCheck(`async create`);
+        await GitHub.updateGitHubCheck(`1 ${new Date().toISOString()}`, `async`);
+        await GitHub.updateGitHubCheck(`2 ${new Date().toISOString()}`, `async`, `success`, `completed`);
+        GitHub.forceAsyncTest = false;
+      },
+      TIMEOUT_INFINITE,
+    );
+  }
+});
--- a/src/model/cloud-runner/tests/cloud-runner-hooks.test.ts
+++ b/src/model/cloud-runner/tests/cloud-runner-hooks.test.ts
@@ -30,6 +30,7 @@ commands: echo "test"`;
      projectPath: 'test-project',
      unityVersion: UnityVersioning.determineUnityVersion('test-project', UnityVersioning.read('test-project')),
      targetPlatform: 'StandaloneLinux64',
+      image: 'ubuntu',
      cacheKey: `test-case-${uuidv4()}`,
    };
    CloudRunner.setup(await CreateParameters(overrides));
@@ -51,6 +52,7 @@ commands: echo "test"`;
    it('Should be 1 before and 1 after hook', async () => {
      const overrides = {
        versioning: 'None',
+        image: 'ubuntu',
        projectPath: 'test-project',
        unityVersion: UnityVersioning.determineUnityVersion('test-project', UnityVersioning.read('test-project')),
        targetPlatform: 'StandaloneLinux64',
@@ -72,6 +74,7 @@ commands: echo "test"`;
        unityVersion: UnityVersioning.determineUnityVersion('test-project', UnityVersioning.read('test-project')),
        targetPlatform: 'StandaloneLinux64',
        cacheKey: `test-case-${uuidv4()}`,
+        image: 'ubuntu',
        containerHookFiles: `my-test-step-pre-build,my-test-step-post-build`,
        commandHookFiles: `my-test-hook-pre-build,my-test-hook-post-build`,
      };
@@ -94,7 +97,8 @@ commands: echo "test"`;
      };
      const buildParameter2 = await CreateParameters(overrides);
      const baseImage2 = new ImageTag(buildParameter2);
-      const results2 = await CloudRunner.run(buildParameter2, baseImage2.toString());
+      const results2Object = await CloudRunner.run(buildParameter2, baseImage2.toString());
+      const results2 = results2Object.BuildResults;
      CloudRunnerLogger.log(`run 2 succeeded`);

      const buildContainsBuildSucceeded = results2.includes('Build succeeded');
--- a/src/model/cloud-runner/tests/cloud-runner-image.test.ts
+++ b/src/model/cloud-runner/tests/cloud-runner-image.test.ts
@@ -0,0 +1,51 @@
+import { BuildParameters, ImageTag } from '../..';
+import UnityVersioning from '../../unity-versioning';
+import { Cli } from '../../cli/cli';
+import GitHub from '../../github';
+import setups from './cloud-runner-suite.test';
+
+async function CreateParameters(overrides: any) {
+  if (overrides) {
+    Cli.options = overrides;
+  }
+  const originalValue = GitHub.githubInputEnabled;
+  GitHub.githubInputEnabled = false;
+  const results = await BuildParameters.create();
+  GitHub.githubInputEnabled = originalValue;
+  delete Cli.options;
+
+  return results;
+}
+
+describe('Cloud Runner Image', () => {
+  setups();
+  const testSecretName = 'testSecretName';
+  const testSecretValue = 'testSecretValue';
+  it('Can create valid image from normal config', async () => {
+    // Setup parameters
+    const buildParameter = await CreateParameters({
+      versioning: 'None',
+      projectPath: 'test-project',
+      unityVersion: UnityVersioning.read('test-project'),
+      targetPlatform: 'StandaloneWindows64',
+      customJob: `
+        - name: 'step 1'
+          image: 'ubuntu'
+          commands: 'printenv'
+          secrets:
+            - name: '${testSecretName}'
+              value: '${testSecretValue}'
+        `,
+    });
+    const baseImage = new ImageTag(buildParameter);
+    if (buildParameter.targetPlatform === undefined) {
+      throw new Error(`target platform includes undefined`);
+    }
+    if (baseImage.toString().includes('undefined')) {
+      throw new Error(`Base image ${baseImage.toString()} includes undefined`);
+    }
+    if (baseImage.toString().includes('NaN')) {
+      throw new Error(`Base image ${baseImage.toString()} includes nan`);
+    }
+  }, 1_000_000_000);
+});
--- a/src/model/cloud-runner/tests/cloud-runner-s3-steps.test.ts
+++ b/src/model/cloud-runner/tests/cloud-runner-s3-steps.test.ts
@@ -32,7 +32,8 @@ describe('Cloud Runner pre-built S3 steps', () => {
      };
      const buildParameter2 = await CreateParameters(overrides);
      const baseImage2 = new ImageTag(buildParameter2);
-      const results2 = await CloudRunner.run(buildParameter2, baseImage2.toString());
+      const results2Object = await CloudRunner.run(buildParameter2, baseImage2.toString());
+      const results2 = results2Object.BuildResults;
      CloudRunnerLogger.log(`run 2 succeeded`);

      const build2ContainsBuildSucceeded = results2.includes('Build succeeded');
--- a/src/model/cloud-runner/tests/e2e/cloud-runner-end2end-caching.test.ts
+++ b/src/model/cloud-runner/tests/e2e/cloud-runner-end2end-caching.test.ts
@@ -24,11 +24,13 @@ describe('Cloud Runner Caching', () => {
    it('Run one build it should not use cache, run subsequent build which should use cache', async () => {
      const overrides = {
        versioning: 'None',
+        image: 'ubuntu',
        projectPath: 'test-project',
        unityVersion: UnityVersioning.determineUnityVersion('test-project', UnityVersioning.read('test-project')),
        targetPlatform: 'StandaloneLinux64',
        cacheKey: `test-case-${uuidv4()}`,
        containerHookFiles: `debug-cache`,
+        cloudRunnerBranch: `cloud-runner-develop`,
      };
      if (CloudRunnerOptions.providerStrategy === `k8s`) {
        overrides.containerHookFiles += `,aws-s3-pull-cache,aws-s3-upload-cache`;
@@ -37,7 +39,8 @@ describe('Cloud Runner Caching', () => {
      expect(buildParameter.projectPath).toEqual(overrides.projectPath);

      const baseImage = new ImageTag(buildParameter);
-      const results = await CloudRunner.run(buildParameter, baseImage.toString());
+      const resultsObject = await CloudRunner.run(buildParameter, baseImage.toString());
+      const results = resultsObject.BuildResults;
      const libraryString = 'Rebuilding Library because the asset database could not be found!';
      const cachePushFail = 'Did not push source folder to cache because it was empty Library';
      const buildSucceededString = 'Build succeeded';
@@ -63,12 +66,12 @@ describe('Cloud Runner Caching', () => {

      buildParameter2.cacheKey = buildParameter.cacheKey;
      const baseImage2 = new ImageTag(buildParameter2);
-      const results2 = await CloudRunner.run(buildParameter2, baseImage2.toString());
+      const results2Object = await CloudRunner.run(buildParameter2, baseImage2.toString());
+      const results2 = results2Object.BuildResults;
      CloudRunnerLogger.log(`run 2 succeeded`);

      const build2ContainsCacheKey = results2.includes(buildParameter.cacheKey);
      const build2ContainsBuildSucceeded = results2.includes(buildSucceededString);
-      const build2NotContainsNoLibraryMessage = !results2.includes(libraryString);
      const build2NotContainsZeroLibraryCacheFilesMessage = !results2.includes(
        'There is 0 files/dir in the cache pulled contents for Library',
      );
@@ -77,10 +80,13 @@ describe('Cloud Runner Caching', () => {
      );

      expect(build2ContainsCacheKey).toBeTruthy();
+      expect(results2).toContain('Activation successful');
      expect(build2ContainsBuildSucceeded).toBeTruthy();
+      expect(results2).toContain(buildSucceededString);
+      const splitResults = results2.split('Activation successful');
+      expect(splitResults[splitResults.length - 1]).not.toContain(libraryString);
      expect(build2NotContainsZeroLibraryCacheFilesMessage).toBeTruthy();
      expect(build2NotContainsZeroLFSCacheFilesMessage).toBeTruthy();
-      expect(build2NotContainsNoLibraryMessage).toBeTruthy();
    }, 1_000_000_000);
  }
 });
--- a/src/model/cloud-runner/tests/e2e/cloud-runner-end2end-retaining.test.ts
+++ b/src/model/cloud-runner/tests/e2e/cloud-runner-end2end-retaining.test.ts
@@ -29,7 +29,8 @@ describe('Cloud Runner Retain Workspace', () => {
      expect(buildParameter.projectPath).toEqual(overrides.projectPath);

      const baseImage = new ImageTag(buildParameter);
-      const results = await CloudRunner.run(buildParameter, baseImage.toString());
+      const resultsObject = await CloudRunner.run(buildParameter, baseImage.toString());
+      const results = resultsObject.BuildResults;
      const libraryString = 'Rebuilding Library because the asset database could not be found!';
      const cachePushFail = 'Did not push source folder to cache because it was empty Library';
      const buildSucceededString = 'Build succeeded';
@@ -51,7 +52,8 @@ describe('Cloud Runner Retain Workspace', () => {

      buildParameter2.cacheKey = buildParameter.cacheKey;
      const baseImage2 = new ImageTag(buildParameter2);
-      const results2 = await CloudRunner.run(buildParameter2, baseImage2.toString());
+      const results2Object = await CloudRunner.run(buildParameter2, baseImage2.toString());
+      const results2 = results2Object.BuildResults;
      CloudRunnerLogger.log(`run 2 succeeded`);

      const build2ContainsCacheKey = results2.includes(buildParameter.cacheKey);
@@ -59,7 +61,6 @@ describe('Cloud Runner Retain Workspace', () => {
      const build2ContainsRetainedWorkspacePhrase = results2.includes(`Retained Workspace:`);
      const build2ContainsWorkspaceExistsAlreadyPhrase = results2.includes(`Retained Workspace Already Exists!`);
      const build2ContainsBuildSucceeded = results2.includes(buildSucceededString);
-      const build2NotContainsNoLibraryMessage = !results2.includes(libraryString);
      const build2NotContainsZeroLibraryCacheFilesMessage = !results2.includes(
        'There is 0 files/dir in the cache pulled contents for Library',
      );
@@ -74,7 +75,8 @@ describe('Cloud Runner Retain Workspace', () => {
      expect(build2ContainsBuildSucceeded).toBeTruthy();
      expect(build2NotContainsZeroLibraryCacheFilesMessage).toBeTruthy();
      expect(build2NotContainsZeroLFSCacheFilesMessage).toBeTruthy();
-      expect(build2NotContainsNoLibraryMessage).toBeTruthy();
+      const splitResults = results2.split('Activation successful');
+      expect(splitResults[splitResults.length - 1]).not.toContain(libraryString);
    }, 1_000_000_000);
    afterAll(async () => {
      await SharedWorkspaceLocking.CleanupWorkspace(CloudRunner.lockedWorkspace || ``, CloudRunner.buildParameters);
--- a/src/model/cloud-runner/tests/e2e/cloud-runner-kubernetes.test.ts
+++ b/src/model/cloud-runner/tests/e2e/cloud-runner-kubernetes.test.ts
@@ -0,0 +1,56 @@
+import CloudRunner from '../../cloud-runner';
+import UnityVersioning from '../../../unity-versioning';
+import { Cli } from '../../../cli/cli';
+import CloudRunnerLogger from '../../services/core/cloud-runner-logger';
+import { v4 as uuidv4 } from 'uuid';
+import CloudRunnerOptions from '../../options/cloud-runner-options';
+import setups from '../cloud-runner-suite.test';
+import BuildParameters from '../../../build-parameters';
+import ImageTag from '../../../image-tag';
+
+async function CreateParameters(overrides: any) {
+  if (overrides) {
+    Cli.options = overrides;
+  }
+
+  return await BuildParameters.create();
+}
+
+describe('Cloud Runner Kubernetes', () => {
+  it('Responds', () => {});
+  setups();
+
+  if (CloudRunnerOptions.cloudRunnerDebug) {
+    it('Run one build it using K8s without error', async () => {
+      if (CloudRunnerOptions.providerStrategy !== `k8s`) {
+        return;
+      }
+      process.env.USE_IL2CPP = 'false';
+      const overrides = {
+        versioning: 'None',
+        projectPath: 'test-project',
+        unityVersion: UnityVersioning.determineUnityVersion('test-project', UnityVersioning.read('test-project')),
+        targetPlatform: 'StandaloneLinux64',
+        cacheKey: `test-case-${uuidv4()}`,
+        providerStrategy: 'k8s',
+        buildPlatform: 'linux',
+      };
+      const buildParameter = await CreateParameters(overrides);
+      expect(buildParameter.projectPath).toEqual(overrides.projectPath);
+
+      const baseImage = new ImageTag(buildParameter);
+      const resultsObject = await CloudRunner.run(buildParameter, baseImage.toString());
+      const results = resultsObject.BuildResults;
+      const libraryString = 'Rebuilding Library because the asset database could not be found!';
+      const cachePushFail = 'Did not push source folder to cache because it was empty Library';
+      const buildSucceededString = 'Build succeeded';
+
+      expect(results).toContain('Collected Logs');
+      expect(results).toContain(libraryString);
+      expect(results).toContain(buildSucceededString);
+      expect(results).not.toContain(cachePushFail);
+
+      CloudRunnerLogger.log(`run 1 succeeded`);
+    }, 1_000_000_000);
+  }
+});