actions/goreportcard
2
0
Fork 0
mirror of https://github.com/gojp/goreportcard.git synced 2026-01-29 06:49:05 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #31 from russmack/FixColonMessageSplit

Browse Source 
Fixed splitting lines on colons when line includes eg i := range.
This commit is contained in:
Shawn Smith
2015-08-18 22:24:42 +08:00
parent 11d5c1db38 b598dd3c5d
commit 59e2cc8750
1 changed files with 13 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
check/utils.go
View File

@@ -91,20 +91,25 @@ func getFileSummary(filename, dir, cmd, out string) (FileSummary, error) {
}
split := strings.Split(string(out), "\n")
for _, sp := range split[0 : len(split)-1] {
parts := strings.Split(sp, ":")
msg := sp
if cmd != "gocyclo" {
msg = parts[len(parts)-1]
var loc string
if cmd == "gocyclo" {
s := strings.SplitN(sp, " ", 2)
loc = s[1]
} else {
s := strings.SplitN(sp, ": ", 2)
loc = s[0]
if len(s) > 1 {
msg = s[1]
}
}
e := Error{ErrorString: msg}
switch cmd {
case "golint", "gocyclo", "vet":
ls := strings.Split(sp, ":")
if len(ls) >= 2 && strings.Contains(sp, filename) {
ls := strings.Split(loc, ":")
if len(ls) >= 1 && strings.Contains(loc, filename) {
idx := len(ls) - 2
if cmd == "golint" {
idx = len(ls) - 3
}
if cmd == "vet" {
idx = 1
}