actions/goreportcard
2
0
Fork 0
mirror of https://github.com/gojp/goreportcard.git synced 2026-01-28 22:39:05 +08:00
Code Issues Packages Projects Releases Wiki Activity

Minor code cleanup in error handling.

Browse Source
This commit is contained in:
tariqibrahim
2017-11-14 23:02:26 -08:00
parent 64fe3a2238
commit 6f5b312295
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
handlers/check.go
View File

@@ -32,8 +32,7 @@ func CheckHandler(w http.ResponseWriter, r *http.Request) {
repo, err := download.Clean(r.FormValue("repo"))
if err != nil {
log.Println("ERROR: from download.Clean:", err)
w.WriteHeader(http.StatusBadRequest)
w.Write([]byte(`Could not download the repository: ` + err.Error()))
http.Error(w, "Could not download the repository: "+err.Error(), http.StatusBadRequest)
return
}
@@ -43,15 +42,14 @@ func CheckHandler(w http.ResponseWriter, r *http.Request) {
resp, err := newChecksResp(repo, forceRefresh)
if err != nil {
log.Println("ERROR: from newChecksResp:", err)
w.WriteHeader(http.StatusBadRequest)
w.Write([]byte(`Could not download the repository.`))
http.Error(w, "Could not analyze the repository: "+err.Error(), http.StatusBadRequest)
return
}
respBytes, err := json.Marshal(resp)
if err != nil {
log.Println("ERROR: could not marshal json:", err)
http.Error(w, err.Error(), 500)
http.Error(w, err.Error(), http.StatusInternalServerError)
return
}
@@ -59,7 +57,7 @@ func CheckHandler(w http.ResponseWriter, r *http.Request) {
db, err := bolt.Open(DBPath, 0755, &bolt.Options{Timeout: 1 * time.Second})
if err != nil {
log.Println("Failed to open bolt database: ", err)
http.Error(w, err.Error(), 500)
http.Error(w, err.Error(), http.StatusInternalServerError)
return
}
defer db.Close()