fix: address PR review feedback from GabLeRoux

- Update kubectl to v1.34.1 (latest stable)
- Add provider documentation explaining what a provider is
- Fix typo: "versions" -> "tags" in best practices

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
frostebite
2026-01-28 06:55:29 +00:00
parent 682d2db50e
commit 4393f04d38
2 changed files with 10 additions and 2 deletions

View File

@@ -51,7 +51,7 @@ jobs:
- name: Set up kubectl
uses: azure/setup-kubectl@v4
with:
version: 'v1.31.0'
version: 'v1.34.1'
- name: Install k3d
run: |
curl -s https://raw.githubusercontent.com/k3d-io/k3d/main/install.sh | bash

View File

@@ -1,5 +1,13 @@
# Provider Loader Dynamic Imports
## What is a Provider?
A **provider** is a pluggable backend that Cloud Runner uses to run builds and workflows. Examples include **AWS**, **Kubernetes**, or local execution. Each provider implements the [ProviderInterface](https://github.com/game-ci/unity-builder/blob/main/src/model/cloud-runner/providers/provider-interface.ts), which defines the common lifecycle methods (setup, run, cleanup, garbage collection, etc.).
This abstraction makes Cloud Runner flexible: you can switch execution environments or add your own provider (via npm package, GitHub repo, or local path) without changing the rest of your pipeline.
## Dynamic Provider Loading
The provider loader now supports dynamic loading of providers from multiple sources including local file paths, GitHub repositories, and NPM packages.
## Features
@@ -207,7 +215,7 @@ The provider loader can be configured through environment variables:
## Best Practices
1. **Use specific branches or versions**: Always specify the branch or specific tag when loading from GitHub
1. **Use specific branches or tags**: Always specify the branch or specific tag when loading from GitHub
2. **Implement proper error handling**: Wrap provider loading in try-catch blocks
3. **Clean up regularly**: Use the cleanup utility to manage cache size
4. **Test locally first**: Test providers locally before deploying