integrate PR #686

temp/pr-686-notes.md

@@ -1,47 +0,0 @@
-# PR #686 Integration Notes
-
-## PR Details
-- **Title:** Fixed AWS to work when no secrets specified
-- **Author:** brian-golfplusvr
-- **Base:** main
-- **Head:** brian-golfplusvr:main
-
-## Integration Status: COMPLETE
-
-### Changes Applied
-
-1. **AWS Secrets Fix** ✅
-   - `task-definition-formation.ts`: Removed hardcoded `Secrets:` key from template
-   - `aws-cloud-formation-templates.ts`: Added `Secrets:` key to `getSecretDefinitionTemplate()` function
-   - **Result**: CloudFormation now works with OR without secrets
-
-2. **Clone Depth Parameter** ✅
-   - Added `cloneDepth` action input (default: 50, use 0 for full clone)
-   - Added getter in `cloud-runner-options.ts`
-   - Added property in `build-parameters.ts`
-   - Updated `remote-client/index.ts` to use `--depth` parameter
-
-3. **Cloud Runner Repo Name** ✅
-   - Added `cloudRunnerRepoName` action input (default: game-ci/unity-builder)
-   - Added getter in `cloud-runner-options.ts`
-   - Added property in `build-parameters.ts`
-   - Updated `cloud-runner-folders.ts` to use dynamic repo name
-
-4. **Image Rolling Version Type** ✅
-   - Changed `imageRollingVersion` from `number` to `string` in `image-tag.ts`
-   - Allows dot versions (e.g., "3.1.0")
-
-### Files Modified
-- `action.yml` - Added cloneDepth, cloudRunnerRepoName inputs
-- `src/model/build-parameters.ts` - Added properties
-- `src/model/cloud-runner/options/cloud-runner-options.ts` - Added getters
-- `src/model/cloud-runner/options/cloud-runner-folders.ts` - Dynamic repo URL
-- `src/model/cloud-runner/remote-client/index.ts` - Clone depth parameter
-- `src/model/cloud-runner/providers/aws/cloud-formations/task-definition-formation.ts` - Secrets fix
-- `src/model/cloud-runner/providers/aws/aws-cloud-formation-templates.ts` - Secrets fix
-- `src/model/image-tag.ts` - imageRollingVersion type change
-
-### Not Applicable (Already in our branch)
-- AWS SDK v3 migration (we already have it)
-- Additional debug logging (we have better logging)
-- Stack wait time config (we already have CLOUD_RUNNER_AWS_STACK_WAIT_TIME)