Fixed addressable build failing on Addressable 1.17.17+ (#262)

* Add linux read permissions and cleanup build.sh

* More verbose dirty branch

* Simplify added verbosity

.github/ISSUE_TEMPLATE/feature_request.md

@@ -1,6 +1,6 @@
 ---
 name: Feature request
-about: Suggest an improvement or now feature
+about: Suggest an improvement, or a new feature
 title: ''
 labels: ''
 assignees: ''

dist/default-build-script/Assets/Editor/UnityBuilderAction/Builder.cs

@@ -53,14 +53,11 @@ namespace UnityBuilderAction
       if (addressableAssetSettingsType != null)
       {
         // ReSharper disable once PossibleNullReferenceException, used from try-catch
-        void CallAddressablesMethod(string methodName, object[] args) => addressableAssetSettingsType
-          .GetMethod(methodName, BindingFlags.Static | BindingFlags.Public)
-          .Invoke(null, args);
-
         try
         {
-          CallAddressablesMethod("CleanPlayerContent", new object[] { null });
-          CallAddressablesMethod("BuildPlayerContent", Array.Empty<object>());
+          addressableAssetSettingsType.GetMethod("CleanPlayerContent", BindingFlags.Static | BindingFlags.Public)
+                .Invoke(null, new object[] {null});
+          addressableAssetSettingsType.GetMethod("BuildPlayerContent", new Type[0]).Invoke(null, new object[0]);
         }
         catch (Exception e)
         {

dist/index.js

@@ -2169,7 +2169,12 @@ class Versioning {
     static isDirty() {
         return __awaiter(this, void 0, void 0, function* () {
             const output = yield this.git(['status', '--porcelain']);
-            return output !== '';
+            const isDirty = output !== '';
+            if (isDirty) {
+                core.warning('Changes were made to the following files and folders:\n');
+                core.warning(output);
+            }
+            return isDirty;
         });
     }
     /**

dist/steps/build.sh

@@ -65,6 +65,7 @@ fi
 #
 # Create Android keystore, if needed
 #
+
 if [[ -z $ANDROID_KEYSTORE_NAME || -z $ANDROID_KEYSTORE_BASE64 ]]; then
   echo "Not creating Android keystore."
 else
@@ -73,16 +74,16 @@ else
 fi
 
 #
-# Display custom parameters
+# Pre-build debug information
 #
-echo "Using custom parameters $CUSTOM_PARAMETERS."
 
-# The build specification below may require Unity 2019.2.11f1 or later (not tested below).
-# Reference: https://docs.unity3d.com/2019.3/Documentation/Manual/CommandLineArguments.html
+echo ""
+echo "###########################"
+echo "#    Custom parameters    #"
+echo "###########################"
+echo ""
 
-#
-# Build info
-#
+echo "$CUSTOM_PARAMETERS"
 
 echo ""
 echo "###########################"
@@ -100,14 +101,20 @@ echo "#    Project directory    #"
 echo "###########################"
 echo ""
 
-ls -alh $UNITY_PROJECT_PATH
+ls -alh "$UNITY_PROJECT_PATH"
+
+#
+# Build
+#
 
 echo ""
 echo "###########################"
-echo "#    Building platform    #"
+echo "#    Building project     #"
 echo "###########################"
 echo ""
 
+# Reference: https://docs.unity3d.com/2019.3/Documentation/Manual/CommandLineArguments.html
+
 unity-editor \
   -nographics \
   -logfile /dev/stdout \
@@ -136,17 +143,24 @@ else
   echo "Build failed, with exit code $BUILD_EXIT_CODE";
 fi
 
-# Add permissions to make app runnable
-if [[ "$BUILD_TARGET" == "StandaloneOSX" ]]; then
-  ADD_PERMISSIONS_PATH=$BUILD_PATH_FULL/StandaloneOSX.app/Contents/MacOS/*
-  echo "Making the following path executable: $ADD_PERMISSIONS_PATH"
-  chmod +x $ADD_PERMISSIONS_PATH
+#
+# Permissions
+#
+
+# Make a given user owner of all artifacts
+if [[ -n "$CHOWN_FILES_TO" ]]; then
+  chown -R "$CHOWN_FILES_TO" "$BUILD_PATH_FULL"
+  chown -R "$CHOWN_FILES_TO" "$UNITY_PROJECT_PATH"
 fi
 
+# Add read permissions for everyone to all artifacts
+chmod -R a+r "$BUILD_PATH_FULL"
+chmod -R a+r "$UNITY_PROJECT_PATH"
 
-if [[ -n "$CHOWN_FILES_TO" ]]; then
-  chown -R $CHOWN_FILES_TO $BUILD_PATH_FULL
-  chown -R $CHOWN_FILES_TO $UNITY_PROJECT_PATH
+# Add execute permissions to specific files
+if [[ "$BUILD_TARGET" == "StandaloneOSX" ]]; then
+  OSX_EXECUTABLE_PATH="$BUILD_PATH_FULL/StandaloneOSX.app/Contents/MacOS/*"
+  chmod +x "$OSX_EXECUTABLE_PATH"
 fi
 
 #
@@ -155,7 +169,7 @@ fi
 
 echo ""
 echo "###########################"
-echo "#     Build directory     #"
+echo "#       Build output      #"
 echo "###########################"
 echo ""
 

src/model/versioning.ts

@@ -251,8 +251,14 @@ export default class Versioning {
    */
   static async isDirty() {
     const output = await this.git(['status', '--porcelain']);
+    const isDirty = output !== '';
 
-    return output !== '';
+    if (isDirty) {
+      core.warning('Changes were made to the following files and folders:\n');
+      core.warning(output);
+    }
+
+    return isDirty;
   }
 
   /**